feat: Implement project enabling/disabling functionality#6363
feat: Implement project enabling/disabling functionality#6363niladrix719 wants to merge 12 commits intopipe-cd:masterfrom
Conversation
Signed-off-by: “niladrix719” <niladrix719@gmail.com>
niladrix719
requested review from
Warashi,
hongky-1994,
khanhtc1202 and
t-kikuc
Signed-off-by: “niladrix719” <niladrix719@gmail.com>
Signed-off-by: “niladrix719” <niladrix719@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #6363 +/- ##
===========================================
- Coverage 28.82% 17.50% -11.33%
===========================================
Files 560 7 -553
Lines 59941 920 -59021
===========================================
- Hits 17277 161 -17116
+ Misses 41343 738 -40605
+ Partials 1321 21 -1300 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: “niladrix719” <niladrix719@gmail.com>
Signed-off-by: “niladrix719” <niladrix719@gmail.com>
Signed-off-by: “niladrix719” <niladrix719@gmail.com>
|
I think we can still merge this PR, since it will trigger publish_tool.yaml to publish a new version of the codegen image. We can then update the Makefile and gen.yaml image in a later PR. What do you think, @khanhtc1202? Or, we could update the image and use the new one in this PR, but I don’t think I have write access to push a new image version. |
|
@niladrix719 Since the codegen check is a required step in the CI, I think it's better to fix the broken CI first 👀 |
|
okay can you help me publish the new image, so I can use it here |
|
@niladrix719 sure, sorry for the missed 🙏 |
pkg/jwt/jwt.go
Outdated
|
|
||
| // NewClaims creates a new claims for a given github user. | ||
| func NewClaims(githubUserID, avatarURL string, ttl time.Duration, role model.Role) *Claims { | ||
| func NewClaims(githubUserID, avatarURL string, ttl time.Duration, role *model.Role) *Claims { |
There was a problem hiding this comment.
Why do we need to change this to pointer?
There was a problem hiding this comment.
just thought it would be better, should I revert this
There was a problem hiding this comment.
Then it should be a separated PR for that, to reduce the change we have in each PR 🙏
tool/codegen/protoc-gen-auth/file.go
Outdated
| zap.String("project", projectID), | ||
| ) | ||
| return nil, fmt.Errorf("project %s is disabled", projectID) | ||
| } |
There was a problem hiding this comment.
We can remove this file change and do it by another PR to resolve the codegen diff 👀
Removed logging and error handling for disabled projects. Signed-off-by: Niladri Adhikary <91966855+niladrix719@users.noreply.github.com>
Signed-off-by: “niladrix719” <niladrix719@gmail.com>
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Signed-off-by: Niladri Adhikary <niladrix719@gmail.com>
|
Hey @khanhtc1202 can you check now |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
2 participants
What this PR does:
Why we need it:
Which issue(s) this PR fixes:
Fixes #4754